[webkit-reviews] review granted: [Bug 56909] Add simplified layout path optimization for overflow recomputation and for positioned objects inside relative positioned containers. : [Attachment 86866] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 56909: Add simplified layout path optimization for overflow recomputation
and for positioned objects inside relative positioned containers.
https://bugs.webkit.org/show_bug.cgi?id=56909

Attachment 86866: Patch
https://bugs.webkit.org/attachment.cgi?id=86866&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=86866&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:879
> +		   for (unsigned i = 0; i < positionedObjects.size(); ++i)

size() returns a size_t so we typically use a size_t for the index variable

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2098
> +	       for (unsigned i = 0; i < trailingPositionedBoxes.size(); ++i) {

same comment about size_t