[webkit-reviews] review denied: [Bug 56138] Data race between ~WorkerFileSystemCallbacksBridge and runTasksOnWorkerThread : [Attachment 86901] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 56138: Data race between ~WorkerFileSystemCallbacksBridge and
runTasksOnWorkerThread
https://bugs.webkit.org/show_bug.cgi?id=56138

Attachment 86901: Patch
https://bugs.webkit.org/attachment.cgi?id=86901&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86901&action=review

Just a few things but they may change the code a bit so I'd like to see it one
more time.

> Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:89
>      static MainThreadFileSystemCallbacks*
createLeakedPtr(PassRefPtr<WorkerFileSystemCallbacksBridge> bridge, const
String& mode)

This should no longer be a PassRefPtr (which implies that it keeps the ref
count in some way and that is clearly not the case anymore).

> Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp:385
>      { // Let go of the mutex before possibly deleting this due to
m_selfRef.clear().

This comment and the brace are now out of date.