[webkit-reviews] review granted: [Bug 56655] [GTK] Expose the AtkValue interface for WAI-ARIA sliders : [Attachment 86703] Patch proposal + Layout test

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 56655: [GTK] Expose the AtkValue interface for WAI-ARIA sliders
https://bugs.webkit.org/show_bug.cgi?id=56655

Attachment 86703: Patch proposal + Layout test
https://bugs.webkit.org/attachment.cgi?id=86703&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86703&action=review

> Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:156
> +	   GValue gValue = { 0 };
> +	   atk_value_get_current_value(ATK_VALUE(axObject), &gValue);
> +
> +	   AtkPropertyValues propertyValues;
> +	   propertyValues.property_name = "accessible-value";
> +	   propertyValues.new_value = gValue;
> +

Would it make sense to simply do:

atk_value_get_current_value(ATK_VALUE(axObject), &propertyValues.new_value);