[webkit-reviews] review requested: [Bug 56825] [Qt] fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails : [Attachment 86933] Style and cosmetic fixes.

[bugzilla-daemon at webkit.org]

Jarkko Sakkinen <jarkko.j.sakkinen at gmail.com> has asked  for review:
Bug 56825: [Qt]
fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html fails
https://bugs.webkit.org/show_bug.cgi?id=56825

Attachment 86933: Style and cosmetic fixes.
https://bugs.webkit.org/attachment.cgi?id=86933&action=review

------- Additional Comments from Jarkko Sakkinen <jarkko.j.sakkinen at gmail.com>
Comment on common implementation (summary of the flood in IRC):

If you want common implementation there must a driver class for these features
(platform dependent):
- Symbol resolution (GC3DOGL assumes that symbols are resolved)
- Some calls differ whether compiled for OGL ES 2 or desktop GL. ES 2.0
flagging is not done in the GC3DOGL.
- Context handling
- Painting of canvas

These already cover so huge chunk of GC3DQt that I think it would not be a good
idea to go for common. Or at least there has to be good answers where platform
dependent parts are placed. I think this is something that should be considered
in long-term but not for the first release at least :)