[webkit-reviews] review granted: [Bug 54290] rename Node::isContentEditable and all call sites to rendererIsEditable : [Attachment 86768] fix patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 01:45:08 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Chang Shu <cshu at webkit.org>'s
request for review:
Bug 54290: rename Node::isContentEditable and all call sites to
rendererIsEditable
https://bugs.webkit.org/show_bug.cgi?id=54290

Attachment 86768: fix patch 3
https://bugs.webkit.org/attachment.cgi?id=86768&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86768&action=review

> Source/WebCore/ChangeLog:11
> +	   Code optimization. No new tests.

Nit: this isn't really an optimization, right?	It's more of a refactoring.

> Source/WebKit/chromium/src/WebNode.cpp:150
> -    return m_private->isContentEditable();
> +    return m_private->rendererIsEditable();

It's not great that WebKit code is referring to renderIsEditable.  Ideally,
rendererIsEditable will be WebCore's implementation detail and won't be exposed
to WebKit layer at all.  We can of course make such a change when you add
updateStyleIfNeeded to isContentEditable.


More information about the webkit-reviews mailing list