[webkit-reviews] review denied: [Bug 57091] <keygen> does not support autofocus : [Attachment 86905] Patch

Fri Mar 25 00:44:06 PDT 2011

Kent Tamura <tkent at chromium.org> has denied Dominic Cooney
<dominicc at google.com>'s request for review:
Bug 57091: <keygen> does not support autofocus
https://bugs.webkit.org/show_bug.cgi?id=57091

Attachment 86905: Patch
https://bugs.webkit.org/attachment.cgi?id=86905&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86905&action=review

> LayoutTests/fast/forms/autofocus-keygen.html:16
> +    shouldBe('focusedElement', 'document.querySelector("keygen")');

I think document.activeElement works instead of focusedElement.

> LayoutTests/fast/forms/autofocus-keygen.html:23
> +successfullyParsed = true;
> +</script>
> +</head>
> +<body onload="onLoad();">

This doesn't follow usual style of our layout tests.

Please do:
 - remove layoutTestController.dumpAsText() in the second <script>
 - add window.jsTestisAsync = true in the second <script>
 - add finishJSTest() at the bottom of onLoad()
 - add <script> for js/resources/js-test-post.js at the bottom of <body>