[webkit-reviews] review denied: [Bug 56989] webkit-patch should be more intelligent about whether a bug applies to a patch : [Attachment 86882] Updated patch based on Ojan's feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 25 00:24:09 PDT 2011


Eric Seidel <eric at webkit.org> has denied  review:
Bug 56989: webkit-patch should be more intelligent about whether a bug applies
to a patch
https://bugs.webkit.org/show_bug.cgi?id=56989

Attachment 86882: Updated patch based on Ojan's feedback
https://bugs.webkit.org/attachment.cgi?id=86882&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86882&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:53
> +def parse_bug_id(message, show_bug_url_on_own_line=True):

What does "show_bug_url_on_own_line" mean? 

I also wonder if this shouldn't ust be a separate function.  Why is it OK to
find http://webkit.org/b/ links not on their own line?


More information about the webkit-reviews mailing list