[webkit-reviews] review granted: [Bug 56989] webkit-patch should be more intelligent about whether a bug applies to a patch : [Attachment 86882] Updated patch based on Ojan's feedback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 24 22:35:38 PDT 2011


Ojan Vafai <ojan at chromium.org> has granted Andrew Foster
<andrewf at chromium.org>'s request for review:
Bug 56989: webkit-patch should be more intelligent about whether a bug applies
to a patch
https://bugs.webkit.org/show_bug.cgi?id=56989

Attachment 86882: Updated patch based on Ojan's feedback
https://bugs.webkit.org/attachment.cgi?id=86882&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86882&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:61
> +	       "^\s*" + Bugzilla.bug_server_regex +
"show_bug\.cgi\?id=(?P<bug_id>\d+)(&ctype=xml)?$",

Interesting. If we're going to handle this, we should probably also handle the
case where ctype comes before the id?


More information about the webkit-reviews mailing list