[webkit-reviews] review denied: [Bug 57079] DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions : [Attachment 86881] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Benjamin (Ben) Kalman
<kalman at chromium.org>'s request for review:
Bug 57079: DeleteSelectionCommand::removeNode tries to insert block placeholder
in non-editable table cell positions
https://bugs.webkit.org/show_bug.cgi?id=57079

Attachment 86881: Patch
https://bugs.webkit.org/attachment.cgi?id=86881&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86881&action=review

> Source/WebCore/editing/DeleteSelectionCommand.cpp:346
> +	   Position firstEditablePositionInChild =
firstEditablePositionInNode(child);
> +	   if (firstEditablePositionInChild.isNotNull())
> +	       return firstEditablePositionInChild;
> +	   child = child->nextSibling();

I don't think this function needs be recursive.  Can't you just
traverseNextNode(node)?