[webkit-reviews] review granted: [Bug 57058] Hookup the UIProcess WebIconDatabase to a WebCore::IconDatabase as its implementation : [Attachment 86846] Patch v1

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 57058: Hookup the UIProcess WebIconDatabase to a WebCore::IconDatabase as
its implementation
https://bugs.webkit.org/show_bug.cgi?id=57058

Attachment 86846: Patch v1
https://bugs.webkit.org/attachment.cgi?id=86846&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86846&action=review

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:62
> +	   LOG_ERROR("Icon database is already open, can only have its path set
once.");

This error log could be worded better.

> Source/WebKit2/UIProcess/WebIconDatabase.cpp:74
> +    if (!m_iconDatabaseImpl->open(WebCore::directoryName(path),
WebCore::pathGetFileName(path))) {
> +	   LOG_ERROR("Unable to open WebKit2 icon database on disk");
> +	   m_iconDatabaseImpl.clear();
> +	   WebCore::setGlobalIconDatabase(0);
> +    }
> +    WebCore::setGlobalIconDatabase(m_iconDatabaseImpl.get());

I think a using namespace WebCore; at the top would make this nicer.