[webkit-reviews] review granted: [Bug 57050] Untangle dependency between event ancestor chain computation and InspectorDOMAgent. : [Attachment 86826] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 24 15:02:58 PDT 2011
Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 57050: Untangle dependency between event ancestor chain computation and
InspectorDOMAgent.
https://bugs.webkit.org/show_bug.cgi?id=57050
Attachment 86826: Patch
https://bugs.webkit.org/attachment.cgi?id=86826&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86826&action=review
> Source/WebCore/ChangeLog:9
> + Inspector's list of event listeners does not need to invoke
Node::getEventListeners,
> + because it simply needs a list of all ancestors of a node.
How did you know it only needed that?
> Source/WebCore/ChangeLog:16
> + (WebCore::Node::dispatchGenericEvent): Move inDocument check out
here from
> + getEventAncestors.
Why?
> Source/WebCore/inspector/InspectorDOMAgent.cpp:748
> // The Node's Event Ancestors (not including self)
I don’t think that calling these “Event Ancestors” is all that clear since it’s
not necessarily the same objects you’d send a DOM event to.
More information about the webkit-reviews
mailing list