[webkit-reviews] review granted: [Bug 49830] WebKit2: Add Trackpoint driver hack to support IBM trackpads : [Attachment 86821] [PATCH] Fix v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 24 13:37:59 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 49830: WebKit2: Add Trackpoint driver hack to support IBM trackpads
https://bugs.webkit.org/show_bug.cgi?id=49830

Attachment 86821: [PATCH] Fix v2
https://bugs.webkit.org/attachment.cgi?id=86821&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86821&action=review

> Source/WebKit2/UIProcess/win/WebView.cpp:294
> +	   // scrollbars, so the WebView will receive WM_VSCROLl and WM_HSCROLL
messages.

WM_VSCROLl should be WM_VSCROLL.

> Source/WebKit2/UIProcess/win/WebView.cpp:746
> +    for (int i = 0; i < WTF_ARRAY_LENGTH(trackPointKeys); ++i) {

i should be a size_t.


More information about the webkit-reviews mailing list