[webkit-reviews] review granted: [Bug 57041] [fileapi] Make FileError and FileException accessible from WorkerContext : [Attachment 86808] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Adam Klein <adamk at chromium.org>'s
request for review:
Bug 57041: [fileapi] Make FileError and FileException accessible from
WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=57041

Attachment 86808: Patch
https://bugs.webkit.org/attachment.cgi?id=86808&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86808&action=review

r+ but cq- due to indenting issue.

> Source/WebCore/workers/WorkerContext.idl:116
> +	   attribute [EnabledAtRuntime=FileSystem] FlagsConstructor Flags;

The indentation is on purpose and follows the format done typically in spec
iirc.

Hint look at where attribute would be if readonly preceded it.

> Source/WebCore/workers/WorkerContext.idl:117
> +	   attribute [EnabledAtRuntime=FileSystem] FileErrorConstructor
FileError;

Ok, FileError.idl has NoStaticTables attribute.

> Source/WebCore/workers/WorkerContext.idl:118
> +	   attribute [EnabledAtRuntime=FileSystem] FileExceptionConstructor
FileException;

Ok, FileException.idl has NoStaticTables attribute.