[webkit-reviews] review denied: [Bug 56602] [Chromium] Inspector does not always shows transferred size correctly (e.g. gzipped/chunked content) : [Attachment 86817] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 56602: [Chromium] Inspector does not always shows transferred size
correctly (e.g. gzipped/chunked content)
https://bugs.webkit.org/show_bug.cgi?id=56602

Attachment 86817: Patch
https://bugs.webkit.org/attachment.cgi?id=86817&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86817&action=review

> Source/WebKit/chromium/public/WebDevToolsAgent.h:97
> +    virtual void didReceiveData(unsigned long resourceId, int length, int
lengthReceived) = 0;

This will break upon the roll. You should make 3 patches:
1) add new method, preserve old method
- wait until deps are rolled
2) migrate chromium to the new method
3) nuke old method upstream