[webkit-reviews] review denied: [Bug 54969] [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation : [Attachment 86512] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Robert Sesek
<rsesek at chromium.org>'s request for review:
Bug 54969: [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput
implementation
https://bugs.webkit.org/show_bug.cgi?id=54969

Attachment 86512: Patch
https://bugs.webkit.org/attachment.cgi?id=86512&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86512&action=review

The gist looks great to me. You've done well whittling down redudancies! I'd
like two peeps to take a look at this before landing: rniwa (ranges/editing
stuff) and weinig (webkit2 stuff). r- to nit.

> Source/WebCore/ChangeLog:16
> +	   * WebCore.exp.in:
> +	   * dom/Range.cpp:
> +	   (WebCore::Range::getLocationAndLength):
> +	   * dom/Range.h:
> +	   * page/Frame.cpp:
> +	   (WebCore::Frame::rangeForPoint):
> +	   * page/Frame.h:

This is sad and lonely. I'd like it to be full of life and meaning.

> Source/WebKit/chromium/ChangeLog:28
> +	   * WebKit.gyp:
> +	   * public/WebFrame.h:
> +	   * public/WebWidget.h:
> +	   * public/mac/WebTextHelper.h: Added.
> +	   * src/WebFrameImpl.cpp:
> +	   (WebKit::WebFrameImpl::firstRectForCharacterRange):
> +	   (WebKit::WebFrameImpl::characterIndexForPoint):
> +	   * src/WebFrameImpl.h:
> +	   * src/WebPopupMenuImpl.cpp:
> +	   (WebKit::WebPopupMenuImpl::compositionRange):
> +	   (WebKit::WebPopupMenuImpl::caretOrSelectionRange):
> +	   * src/WebPopupMenuImpl.h:
> +	   * src/WebViewImpl.cpp:
> +	   (WebKit::WebViewImpl::compositionRange):
> +	   (WebKit::WebViewImpl::caretOrSelectionRange):
> +	   * src/WebViewImpl.h:
> +	   * src/mac/WebTextHelper.mm: Added.
> +	   (WebKit::getWebFrameImpl):
> +	   (WebKit::rangeScope):
> +	   (WebKit::WebTextHelper::WebTextHelper):
> +	   (WebKit::WebTextHelper::substringInRange):

Ditto. At least explain what you're doing.