[webkit-reviews] review granted: [Bug 40884] [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles : [Attachment 86801] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 40884: [Qt] When we render WebGL offscreen, color conversion cost a lot of
CPU cycles
https://bugs.webkit.org/show_bug.cgi?id=40884

Attachment 86801: Patch
https://bugs.webkit.org/attachment.cgi?id=86801&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86801&action=review

Pretty nice testing!

> Source/WebKit/qt/tests/benchmarks/webgl/tst_webgl.cpp:31
> +class tst_WebGlPerformance : public QObject {

We normally use GL as uppercase (ie QGLWidget)

> Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:475
> +	   for (int column = 0; column < image1.size().height(); ++column)
> +	       if (image1.pixel(row, column) != image2.pixel(row, column))
> +		   ++diffPixelCount;

That for should really use {}