[webkit-reviews] review denied: [Bug 56354] Web Inspector: empty, non-functional window : [Attachment 86759] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied
opendarwin at lapcatsoftware.com's request for review:
Bug 56354: Web Inspector: empty, non-functional window
https://bugs.webkit.org/show_bug.cgi?id=56354

Attachment 86759: Patch
https://bugs.webkit.org/attachment.cgi?id=86759&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86759&action=review

Thanks for fixing this. I have to put r- for the poor email in the changelog +
nit on the null comparison.

> Source/WebCore/ChangeLog:1
> +2011-03-24  Jeff Johnson  <lapcatsoftware.com>

This should contain your email.

> Source/WebCore/inspector/front-end/Settings.js:117
> +	   if (window.localStorage === null)

I'd rather use window.localStorage == null in order to allow undefined value.
Have you checked that localStorage is null both for v8 and jsc bindings?