[webkit-reviews] review granted: [Bug 56835] Web Inspector: Add tests for HeapSnapshot module : [Attachment 86761] reuse more capabilities of test infrastructure

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 56835: Web Inspector: Add tests for HeapSnapshot module
https://bugs.webkit.org/show_bug.cgi?id=56835

Attachment 86761: reuse more capabilities of test infrastructure
https://bugs.webkit.org/attachment.cgi?id=86761&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86761&action=review

> LayoutTests/http/tests/inspector/heap-snapshot-test.js:1
> +var initialize_HeapSnapshotTest = function() {

You should place your utility test into inspector/profiler since you don't have
tests that require network interaction / serving off http

> LayoutTests/inspector/profiler/heap-snapshot-expected.txt:4
> +Running: heapSnapshotNodeSimpleTest

It would be nice if your tests were printing something to make sure something
is happening.