[webkit-reviews] review granted: [Bug 57035] Web Inspector: render XHRs matching JSON regex as JSON. : [Attachment 86798] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 57035: Web Inspector: render XHRs matching JSON regex as JSON.
https://bugs.webkit.org/show_bug.cgi?id=57035

Attachment 86798: Patch
https://bugs.webkit.org/attachment.cgi?id=86798&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86798&action=review

> Source/WebCore/inspector/front-end/RemoteObject.js:219
> +		   buffer += ", ";

Why not use Array.join instead?

> Source/WebCore/inspector/front-end/ResourceJSONView.js:41
> +    var start = /[{[]/.exec(text);

I vaguely recall that it's not uncommon to use a sequence of all kinds of
brackets instead of while(1) to prevent XSS in this case. I don't remember
details though and in particular whether the brackets should be opening or
closing ones, you may want to double check.

> Source/WebCore/inspector/front-end/ResourceJSONView.js:42
> +    if (start && start.index)

Can it be a valid JSON string if it doesn't contain no { nor [ ?