[webkit-reviews] review granted: [Bug 49016] REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js : [Attachment 86733] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 49016: REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016

Attachment 86733: Patch
https://bugs.webkit.org/attachment.cgi?id=86733&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86733&action=review

> Source/WebCore/html/HTMLPlugInImageElement.h:46
> +    bool preferPluginsForImages() const { return m_preferPluginsForImages; }


For boolean getters like this we normally try to avoid things that can be
interpreted as verb phrases. That’s why you see the name “should” so often.

So I suggest shouldPreferPlugInsForImages and m_shouldPreferPlugInsForImages.

> Source/WebCore/loader/FrameLoader.cpp:1000
> +    bool isSupportedPluginMIMEType =
PluginDatabase::installedPlugins()->isMIMETypeRegistered(mimeType);

The word “supported” sounds like a statement about WebKit rather than the
plug-ins.