[webkit-reviews] review denied: [Bug 56948] Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state : [Attachment 86791] Refactored local variable

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jon Lee <jonlee at apple.com>'s request
for review:
Bug 56948: Tabbing from the last focused field to a non-webpage element leaves
the selection in a weird state
https://bugs.webkit.org/show_bug.cgi?id=56948

Attachment 86791: Refactored local variable
https://bugs.webkit.org/attachment.cgi?id=86791&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86791&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1130
> +    if (!isFocused)
> +	  
m_page->focusController()->focusedOrMainFrame()->selection()->clear();

Sam said: “Before this line, you should add RefPtr<WebPage> protect(this)”.