[webkit-reviews] review granted: [Bug 20302] Wrong signbit implementation for solaris platform : [Attachment 86785] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 24 09:53:42 PDT 2011
Darin Adler <darin at apple.com> has granted Ben Taylor
<bentaylor.solx86 at gmail.com>'s request for review:
Bug 20302: Wrong signbit implementation for solaris platform
https://bugs.webkit.org/show_bug.cgi?id=20302
Attachment 86785: Proposed patch which compiles correctly in qt-4.7.1 with
webkit enabled on Solaris 10 with SS12 C++ compiler
https://bugs.webkit.org/attachment.cgi?id=86785&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86785&action=review
> Source/JavaScriptCore/wtf/MathExtras.h:93
> -inline bool signbit(double x) { return x < 0.0; } // FIXME: Wrong for
negative 0.
> +inline bool signbit(double num) { return copysign(1.0, num) < 0; }
I guess you copied the version from MSVC, which is why the variable name is now
num. I would prefer that this file use "x" more consistently or use a word like
"number" rather than "num".
More information about the webkit-reviews
mailing list