[webkit-reviews] review granted: [Bug 46251] [Qt] Some Unicode tests fail with Qt version >= 4.7.0 : [Attachment 86769] Update skip list and add results for bad-sub-protocol-non-ascii.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 24 07:14:06 PDT 2011


Csaba Osztrogonac <ossy at webkit.org> has granted Joe Wild
<joseph.wild at nokia.com>'s request for review:
Bug 46251: [Qt] Some Unicode tests fail with Qt version >= 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=46251

Attachment 86769: Update skip list and add results for
bad-sub-protocol-non-ascii.html
https://bugs.webkit.org/attachment.cgi?id=86769&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86769&action=review

LGTM, r=me with a little changelog modification.
I'll do it, and land it manually.

> LayoutTests/ChangeLog:17
> +	   be more reliable.  Redid to update Skipped lists and add results
> +	   for /bad-sub-protocol-non-ascii.html.
> +
> +	   Note: I did not update platform/qt-wk2/Skipped list.  I was told
> +	   that it did not matter.

We don't need this comment in the ChangeLog:
"Redid to update Skipped lists and add results for
/bad-sub-protocol-non-ascii.html.
 Note: I did not update platform/qt-wk2/Skipped list. I was told that it did
not matter."


More information about the webkit-reviews mailing list