[webkit-reviews] review granted: [Bug 57001] Web Inspector: brush up Network agent API. : [Attachment 86757] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 24 05:40:02 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 57001: Web Inspector: brush up Network agent API.
https://bugs.webkit.org/show_bug.cgi?id=57001

Attachment 86757: Patch
https://bugs.webkit.org/attachment.cgi?id=86757&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86757&action=review

> LayoutTests/http/tests/inspector/network/network-redirect.html:36
> +	   var dataGridNodes = WebInspector.panels.network._dataGrid.children;

swap this two lines?

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:254
> +// FIXME: remove once not user downstream.

not user -> not used, also please file a bug for this and add its number next
to the FIXME


More information about the webkit-reviews mailing list