[webkit-reviews] review denied: [Bug 29595] [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL : [Attachment 86716] patch v4, with comment/changelog fixes

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Caio Marcelo de Oliveira
Filho <caio.oliveira at openbossa.org>'s request for review:
Bug 29595: [Qt] Resetting the URL property of a QWebView results in the current
directory being set as file::-type URL
https://bugs.webkit.org/show_bug.cgi?id=29595

Attachment 86716: patch v4, with comment/changelog fixes
https://bugs.webkit.org/attachment.cgi?id=86716&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Instead of updating those two together, I would prefer a private setter that
does the job:
void setLastRequestedUrl(url) {
    m_hasLastRequestedUrl = true;
    m_lastRequestedUrl = url
}
void reset() {
    m_hasLastRequestedUrl = false;
    m_lastRequestedUrl = KURL();
}

This way, we don't risk future change fuck the state m_hasLastRequestedUrl <-->
m_lastRequestedUrl

Other option to not reset m_lastRequestedUrl and just return that from
QWebFrame::requestedUrl() (?)