[webkit-reviews] review requested: [Bug 12499] External <use> xlink:href references do not work : [Attachment 86746] Draft patch, asking for review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 23 23:23:38 PDT 2011


Cosmin Truta <ctruta at gmail.com> has asked  for review:
Bug 12499: External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Attachment 86746: Draft patch, asking for review
https://bugs.webkit.org/attachment.cgi?id=86746&action=review

------- Additional Comments from Cosmin Truta <ctruta at gmail.com>
I am abandoning the direction taken in the previous patch that involved
SVGResourceOwnerElement, in response to Niko's suggestion in comment #48.

This is a heavily-reworked version of the old patch submitted by Rob Buis in
2010-07-19.
Rob's CachedSVGDocument is replaced with the more generic CachedDocument.
Although CachedDocument is not meant to be SVG-specific, it is conditionally
compiled with #if ENABLED(SVG), because, currently, only SVG needs it.

The ChangeLog entry needs more details, and the external <tref> element is yet
to be handled, perhaps in a different bug.


More information about the webkit-reviews mailing list