[webkit-reviews] review granted: [Bug 56898] [chromium] WebBindings::getRangeImpl() should NULL check its NPObject argument : [Attachment 86741] Patch (part 1) style change

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 56898: [chromium] WebBindings::getRangeImpl() should NULL check its
NPObject argument
https://bugs.webkit.org/show_bug.cgi?id=56898

Attachment 86741: Patch (part 1) style change
https://bugs.webkit.org/attachment.cgi?id=86741&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86741&action=review

> Source/WebKit/chromium/ChangeLog:10
> +	   [chromium] WebBindings::getRangeImpl() should NULL check its
NPObject argument
> +	   https://bugs.webkit.org/show_bug.cgi?id=56898
> +
> +	   Address FIXME I noted/added in r81676.  Wanted to just copy/paste
the checking
> +	   code from elsewhere in the file, but inconsistent argument naming
made it more
> +	   difficult than it need be so, to clean up the commons, add
consistent naming.

This description no longer matches the patch. It's a bit lame, but since you'll
be doing the NULL check in a separate patch, this cleanup should be done on a
different bug.