[webkit-reviews] review denied: [Bug 56965] [chromium] Add traceEvents to compositor : [Attachment 86732] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 23 19:40:23 PDT 2011


Kenneth Russell <kbr at google.com> has denied Nat Duca <nduca at chromium.org>'s
request for review:
Bug 56965: [chromium] Add traceEvents to compositor
https://bugs.webkit.org/show_bug.cgi?id=56965

Attachment 86732: Patch
https://bugs.webkit.org/attachment.cgi?id=86732&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
You should feel free to file a bug against check-webkit-style, but it looks
like it doesn't handle multi-line #defines correctly. If you just make the
TRACE_EVENT macro a single line it will clean up the style error. This is worth
doing.


More information about the webkit-reviews mailing list