[webkit-reviews] review denied: [Bug 56885] WebFrame::createAssociatedURLLoader can't accept WebURLLoaderOptions : [Attachment 86648] Proposed Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 56885: WebFrame::createAssociatedURLLoader can't accept WebURLLoaderOptions
https://bugs.webkit.org/show_bug.cgi?id=56885

Attachment 86648: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=86648&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86648&action=review

Almost there. just a few tiny things.

> Source/WebKit/chromium/ChangeLog:6
> +	   https://bugs.webkit.org/show_bug.cgi?id=56885

This ChangeLog is not informative. It is obvious that the patch adds a
parameter. Good ChangeLog entry tells why (as you did in the bug itself).

> Source/WebKit/chromium/public/WebFrame.h:350
> +    virtual WebURLLoader* createAssociatedURLLoader() = 0;

/FIXME/FIXME:/

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1055
> +// FIXME Remove this overload when clients have been changed to pass
options.

/FIXME/FIXME:/

> Source/WebKit/chromium/src/WebFrameImpl.h:136
> +    // FIXME Remove this overload when clients have been changed to pass
options.

/FIXME/FIXME:/