[webkit-reviews] review granted: [Bug 56948] Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state : [Attachment 86724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 23 18:13:04 PDT 2011


Sam Weinig <sam at webkit.org> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 56948: Tabbing from the last focused field to a non-webpage element leaves
the selection in a weird state
https://bugs.webkit.org/show_bug.cgi?id=56948

Attachment 86724: Patch
https://bugs.webkit.org/attachment.cgi?id=86724&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86724&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1129
> +    FocusController* focusController = m_page->focusController();

Before this line, you should add RefPtr<WebPage> protect(this);  There is also
no need for this local variable.


More information about the webkit-reviews mailing list