[webkit-reviews] review requested: [Bug 29595] [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL : [Attachment 86700] patch v3, more testing, deal with invalid but not empty url, do not translate QUrl to about:blank

[bugzilla-daemon at webkit.org]

Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org> has asked	for
review:
Bug 29595: [Qt] Resetting the URL property of a QWebView results in the current
directory being set as file::-type URL
https://bugs.webkit.org/show_bug.cgi?id=29595

Attachment 86700: patch v3, more testing, deal with invalid but not empty url,
do not translate QUrl to about:blank
https://bugs.webkit.org/attachment.cgi?id=86700&action=review

------- Additional Comments from Caio Marcelo de Oliveira Filho
<caio.oliveira at openbossa.org>
This patch is the negation of the two previous approaches:

- Do not ignore the set of an empty URL.
- Do not translate it to "about:blank".

In practice, WebCore will do the translation for us, except when the QWebFrame
is created. For the sake of compatibility I didn't changed it, it means that
there's this url() == QUrl() state that we have no access anymore.

Also added test suggested by Benjamin, which uses a QUrl that's not empty but
also not valid.