[webkit-reviews] review denied: [Bug 56928] [Qt] Bottom border of an inline is cut if it is 1 pixel wide and left or right border is thicker. : [Attachment 86687] Patch.

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 56928: [Qt] Bottom border of an inline is cut if it is 1 pixel wide and
left or right border is thicker.
https://bugs.webkit.org/show_bug.cgi?id=56928

Attachment 86687: Patch.
https://bugs.webkit.org/attachment.cgi?id=86687&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86687&action=review

> Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp:456
> +    // Force antialiasing hint when drawing a border of 1 pixel width
> +    bool forceAntialiasHint = (npoints == 4 &&
polygon.boundingRect().height() == 1);

Since this is a workaround for a bug in Qt's X11 paint engine, I think we
should make that clear by either:

A) Making the workaround QT_WS_X11 and QPaintEngine::X11 specific (just like
drawLineForText does.)
B) Including a comment about why we're doing this.
C) Both.

I personally prefer C, but all are fine with me. :)