[webkit-reviews] review denied: [Bug 56874] Repeated copy and paste-in-place operation results in increasingly verbose HTML : [Attachment 86650] Patch3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 56874: Repeated copy and paste-in-place operation results in increasingly
verbose HTML
https://bugs.webkit.org/show_bug.cgi?id=56874

Attachment 86650: Patch3
https://bugs.webkit.org/attachment.cgi?id=86650&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86650&action=review

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:941
> +	       if (insertionPos.anchorNode()->isTextNode() &&
insertionPos.offsetInContainerNode())
> +		  
splitTextNodeContainingElement(static_cast<Text*>(insertionPos.anchorNode()),
insertionPos.offsetInContainerNode());

I think this needs one more check, a check that anchorType() is
PositionIsOffsetInAnchor.

>> Source/WebCore/editing/ReplaceSelectionCommand.cpp:945

> 
> I don’t think this is right in the case that the anchor node is a text node.

Rather than
parentNode->childNodes()->item(insertionPos.offsetInContainerNode()) I think we
should pass in insertionPos.computeNodeAfterPosition() here.