[webkit-reviews] review granted: [Bug 56878] WebKit2: Need API to manage the Media Cache : [Attachment 86551] [PATCH] Fix (Applies cleanly to ToT)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 56878: WebKit2: Need API to manage the Media Cache
https://bugs.webkit.org/show_bug.cgi?id=56878

Attachment 86551: [PATCH] Fix (Applies cleanly to ToT)
https://bugs.webkit.org/attachment.cgi?id=86551&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86551&action=review

>> Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp:30
>> +#include "WebContext.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Should fix the sorting here just like the style bot says.

>> Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.h:38
>> +	class ArgumentDecoder;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

This, I think, is a style bot mistake, so OK to leave as is. I’m not sure
everyone else agrees.

> Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.cpp:34
> +#include "WebProcess.h"
> +
> +#include <WebCore/NotImplemented.h>

We don’t leave spaces in cases like this.