[webkit-reviews] review granted: [Bug 56865] Webkit warning: converting to 'unsigned int' from 'double' : [Attachment 86611] This patch resolves the issue pointed out by Adler during the review

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted George Guo <george.guo at nokia.com>'s
request for review:
Bug 56865: Webkit warning: converting to 'unsigned int' from 'double'
https://bugs.webkit.org/show_bug.cgi?id=56865

Attachment 86611: This patch resolves the issue pointed out by Adler during the
review
https://bugs.webkit.org/attachment.cgi?id=86611&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86611&action=review

> Source/JavaScriptCore/runtime/TimeoutChecker.cpp:104
> +    return static_cast<unsigned> ((currentTime() - firstTime) * 1000);

There’s an extra space here after the "<". This is not the normal way we
format.

I’m also concerned. We have many places where we assign from double to an
integer. Is this really the only failure in WebKit of this type?