[webkit-reviews] review requested: [Bug 56861] [Qt] RSS Feed MIME type handling in QtWebkit : [Attachment 86618] update to MIMETypeRegistry.cpp to exclude RSS MIME type handling (take 3)

[bugzilla-daemon at webkit.org]

mario borges <mario.g.borges at nokia.com> has asked  for review:
Bug 56861: [Qt] RSS Feed MIME type handling in QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=56861

Attachment 86618: update to MIMETypeRegistry.cpp to exclude RSS MIME type
handling (take 3)
https://bugs.webkit.org/attachment.cgi?id=86618&action=review

------- Additional Comments from mario borges <mario.g.borges at nokia.com>
Updated the patch which hopefully addresses feedback from Benjamin Poulain.

> The change looks invalid anyway. The mimetypes text/xml and application/xml
are perfectly valide types for WebKit.

They are valid MIME types for WebKit but in Qt WebKit specifically they are
handled by displaying the contents on the screen which is not the desired
handling of those types.

Regarding the lack of test cases, I'm not sure if there is an easy way to show
the Qt WebKit browser's handling of these MIME types on a browser other than
Symbian Qt WebKit browser--which is not available outside of Nokia as far as I
know.  One test site that contains feed based MIME types is
http://w.feedzilla.com/gallery.  If you click on one of the feed links, you get
a new screen with the raw xml content for that feed when opened from the Qt
WebKit based browser.  Other browsers such as Safari and Firefox will handle
the feed content appropriately in that feeds subscription and feed viewing
options are presented.