[webkit-reviews] review granted: [Bug 56890] It is possible to calculate a NaN value for "value" in ScrollbarThemeMac::paint() : [Attachment 86561] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 56890: It is possible to calculate a NaN value for "value" in
ScrollbarThemeMac::paint()
https://bugs.webkit.org/show_bug.cgi?id=56890

Attachment 86561: Patch
https://bugs.webkit.org/attachment.cgi?id=86561&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86561&action=review

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:445
> +	   if (max > 0)
> +	       value = scrollbar->currentPos() / max;

I think the whole word maximum here would be better.