[webkit-reviews] review denied: [Bug 56233] Add --baseline-search-path to NRWT : [Attachment 85554] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 56233: Add --baseline-search-path to NRWT
https://bugs.webkit.org/show_bug.cgi?id=56233

Attachment 85554: Patch
https://bugs.webkit.org/attachment.cgi?id=85554&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85554&action=review

I think this is suboptimal, but I guess we can try it.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:276
> +	   baseline_search_path = map(self._filesystem.normpath,
self.get_option('baseline_search_path', '').split(':'))

: seems like a poor choice for a delimiter since windows drive letters have :
in them.

> Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:267
> +	       [('/tmp/local-baselines', 'fast/test-expected.txt')])

Can you add some tests for windows paths and for relative paths?