[webkit-reviews] review granted: [Bug 56879] OBJECT element with DivX source is always downloaded : [Attachment 86543] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 56879: OBJECT element with DivX source is always downloaded
https://bugs.webkit.org/show_bug.cgi?id=56879

Attachment 86543: Patch
https://bugs.webkit.org/attachment.cgi?id=86543&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86543&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1270
> +	   const Vector<String>& extensions = mimeClassInfo.extensions;
> +
> +	   if (find(extensions.begin(), extensions.end(), extension) !=
extensions.end())
> +	       return true;

Can this use the new Vector::contains()? Should we make
mimeClassInfo.extensions a HashSet?