[webkit-reviews] review requested: [Bug 38696] Unfocused contenteditable element still receives keyboard events and gets modified : [Attachment 86538] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has asked  for review:
Bug 38696: Unfocused contenteditable element still receives keyboard events and
gets modified
https://bugs.webkit.org/show_bug.cgi?id=38696

Attachment 86538: Patch
https://bugs.webkit.org/attachment.cgi?id=86538&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
There are over 600 layout tests with either editing delegate changes, focus
ring rect changes, or both. We could fix the focus ring pixel changes by
explicitly focusing the applicable nodes in the tests, though it's a large
change (over 400 tests appear to have this issue).

Two tests will become totally invalid if we make this change, as both expect an
onFocus handler to fire in a selection or drag-and-drop. These are
- fast/events/content-changed-during-drop.html
- fast/events/5056619.html

Also, fast/events/inputText-never-fired-on-keydown-cancel.html has part of the
test explicitly checking to see if focus follows selection. I've removed that
part of the test in the patch already.

I believe this is a change we want to make. Thoughts?