[webkit-reviews] review granted: [Bug 56869] Make horizontal writing mode a bit on RenderObject for speed : [Attachment 86520] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 56869: Make horizontal writing mode a bit on RenderObject for speed
https://bugs.webkit.org/show_bug.cgi?id=56869

Attachment 86520: Patch
https://bugs.webkit.org/attachment.cgi?id=86520&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86520&action=review

> Source/WebCore/rendering/RenderObject.h:864
> +    bool m_horizontalWritingMode : 1;

Unaligned!

What does this to do:

    // 32 bits have been used here. THERE ARE NO FREE BITS AVAILABLE.

Though by my count this is the 32nd bit. I'm sure we could get rid of
m_isDragging if we need to. What a waste of a bit.