[webkit-reviews] review granted: [Bug 56864] Add the remaining steps to WebCore GYP build : [Attachment 86510] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 22 14:47:47 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 56864: Add the remaining steps to WebCore GYP build
https://bugs.webkit.org/show_bug.cgi?id=56864

Attachment 86510: Patch
https://bugs.webkit.org/attachment.cgi?id=86510&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86510&action=review

> Source/WebCore/gyp/copy-inspector-resources.sh:8
> +rm -f
"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector/WebKit.qrc"


Seems ${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector wants
to be a local variable. :)


More information about the webkit-reviews mailing list