[webkit-reviews] review granted: [Bug 56847] WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling) : [Attachment 86482] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 22 11:24:43 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 56847: WebKit2: Cannot make a selection past the end of the visible page
(no autoscrolling)
https://bugs.webkit.org/show_bug.cgi?id=56847

Attachment 86482: Patch
https://bugs.webkit.org/attachment.cgi?id=86482&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86482&action=review

> Source/WebKit2/Shared/mac/WebEventFactory.mm:45
> +    if (!pressedMouseButtons)
> +	   return WebMouseEvent::NoButton;
> +    if (pressedMouseButtons == 1 << 0)
> +	   return WebMouseEvent::LeftButton;
> +    if (pressedMouseButtons == 1 << 1)
> +	   return WebMouseEvent::RightButton;

Surprising that there aren't constants for these!


More information about the webkit-reviews mailing list