[webkit-reviews] review requested: [Bug 56826] [Qt] Implement fullscreen playback for the GStreamer backend. : [Attachment 86457] Proposed patch.

[bugzilla-daemon at webkit.org]

Alexis Menard <alexis.menard at openbossa.org> has asked  for review:
Bug 56826: [Qt] Implement fullscreen playback for the GStreamer backend.
https://bugs.webkit.org/show_bug.cgi?id=56826

Attachment 86457: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=86457&action=review

------- Additional Comments from Alexis Menard <alexis.menard at openbossa.org>
This patch implement the support in FullScreenVideoQt alongside with the Qt
Multimedia support. I though about reusing the base class
QWebFullScreenVideoHandler of the platform plugin but it required to change the
interface of the plugin and the show(QMediaPlayer*) was also an issue (and I
found very ugly to have a plugin interface with some ifdef inside). The #if
defined(WTF_USE_GSTREAMER) && WTF_USE_GSTREAMER is for moc to compile the class
definition (moc does not expand the USE macro). Any feedback?