[webkit-reviews] review denied: [Bug 56824] [Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4 : [Attachment 86455] Fallback to GL_RGBA on desktop OpenGL.

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jarkko Sakkinen
<jarkko.j.sakkinen at gmail.com>'s request for review:
Bug 56824: [Qt] WebGL: renderbufferStorage() fails with internal format
GL_RGBA4
https://bugs.webkit.org/show_bug.cgi?id=56824

Attachment 86455: Fallback to GL_RGBA on desktop OpenGL.
https://bugs.webkit.org/attachment.cgi?id=86455&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86455&action=review

> Source/WebCore/ChangeLog:10
> +

I would prefer you mention the test you are fixing with this patch in the
changelog. Just so it is explicit how this change is tested.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:1099
> +#if !defined (QT_OPENGL_ES_2)

We usually do not put space between defined and the parenthesis.

> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:1100
> +    if (internalformat == RGBA4 || internalformat == RGB565 ||
internalformat == RGB5_A1)

What about DEPTH_STENCIL and DEPTH_COMPONENT16? (just saw those have special
case in GraphicsContext3DOpenGL).