[webkit-reviews] review granted: [Bug 56802] Clear autofilled flag when reseting a form : [Attachment 86427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 22 00:33:42 PDT 2011


Kent Tamura <tkent at chromium.org> has granted Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 56802: Clear autofilled flag when reseting a form
https://bugs.webkit.org/show_bug.cgi?id=56802

Attachment 86427: Patch
https://bugs.webkit.org/attachment.cgi?id=86427&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86427&action=review

> LayoutTests/fast/forms/reset-autofilled.html:27
> +	   shouldBe(stringify(countAutofilledElements()), '0');

Why stringify() is needed? 
shouldBe('countAutoFilledElements()', '0') doesn't work?

>>> LayoutTests/platform/win/fast/forms/reset-autofilled-expected.txt:4

>> 
>> why does this fail? is there a bug on file?
> 
> This fails because the relevant LayoutTestController method is not
implemented: https://bugs.webkit.org/show_bug.cgi?id=55834

Could you implement it for Windows?


More information about the webkit-reviews mailing list