[webkit-reviews] review requested: [Bug 56787] Expose "webkitIndexedDB" to Workers : [Attachment 86394] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 56787: Expose "webkitIndexedDB" to Workers
https://bugs.webkit.org/show_bug.cgi?id=56787

Attachment 86394: Patch
https://bugs.webkit.org/attachment.cgi?id=86394&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86394&action=review

> LayoutTests/storage/indexeddb/basics-workers.js:11
> +    shouldBeTrue("'webkitIndexedDB' in window");

I don't get it...you set window = self above (in some cases)...?  What exactly
is this testing?

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

what about the above test?

Eventually, all indexedDB tests shoudl run against workers and the main window.
 It's OK to just do a few for now tho.

> Source/WebCore/workers/WorkerContext.h:206
> +

extra new line

> Source/WebCore/workers/WorkerContext.idl:139
> +

extra newline