[webkit-reviews] review granted: [Bug 56783] Actually hook up WebKit2 logging on Mac. : [Attachment 86389] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 21 17:42:11 PDT 2011


Brian Weinstein <bweinstein at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 56783: Actually hook up WebKit2 logging on Mac.
https://bugs.webkit.org/show_bug.cgi?id=56783

Attachment 86389: Patch v1
https://bugs.webkit.org/attachment.cgi?id=86389&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86389&action=review

Please fix the style issues also.

> Source/WebKit2/Platform/mac/Logging.mac.mm:35
> +    if (logLevelString) {

Can this be an early return instead?

> Source/WebKit2/UIProcess/WebContext.cpp:131
> +#endif

I think a blank line after the #endif would be slightly more pleasing on the
eye.


More information about the webkit-reviews mailing list