[webkit-reviews] review denied: [Bug 55644] [fileapi] Add URI resolution support to WorkerContext : [Attachment 86248] Ready for review, tests pass

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Adam Klein <adamk at chromium.org>'s
request for review:
Bug 55644: [fileapi] Add URI resolution support to WorkerContext
https://bugs.webkit.org/show_bug.cgi?id=55644

Attachment 86248: Ready for review, tests pass
https://bugs.webkit.org/attachment.cgi?id=86248&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=86248&action=review

Just a few minor things to address.

> Source/WebCore/fileapi/LocalFileSystem.h:57
> +    void readFileSystem(ScriptExecutionContext*, AsyncFileSystem::Type,
PassOwnPtr<AsyncFileSystemCallbacks>, bool synchronous = false);

Why add this parameter and then ignore it?

> Source/WebCore/workers/WorkerContext.h:136
> +	   void resolveLocalFileSystemURL(const String& url,
PassRefPtr<EntryCallback>, PassRefPtr<ErrorCallback>);

The parameter name successCallback would add information in this case so it
would be good to add it.

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:67
> +void openFileSystemHelper(ScriptExecutionContext* context,
AsyncFileSystem::Type type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks,
bool synchronous, long long size, CreationFlag create)

Function local to file should be "static".