[webkit-reviews] review denied: [Bug 56749] Enable skia gpu rendering for content layers : [Attachment 86375] proposed patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 56749: Enable skia gpu rendering for content layers
https://bugs.webkit.org/show_bug.cgi?id=56749

Attachment 86375: proposed patch
https://bugs.webkit.org/attachment.cgi?id=86375&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Please fix the style issues.

Why doesn't the fbo live on the PlatformCanvas or something further down?  It
seems odd to put that on the ContentLayerChromium.  I feel like we keep
creating this same abstraction multiple times in multiple places.

Additionally, tying this behavior to ENABLE(SKIA_GPU) will make it harder to
evaluate using skia for just canvas 2d vs for everything.  Have you figured out
how we can test these two configurations independently?